-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My new icon pfpay #946
My new icon pfpay #946
Conversation
@beratwallee There are already two icons in our repo for Post Finance: postfinance_card and postfinance_efinance. Those icons are really bad and what you're suggesting here is a significant improvement. Are you able to check if the icon and payment method you're proposing here can replace those payment methods as well? We'd like to keep the repo clean if we can. |
Hi @Jacquesattaque! The icons I provided can't for now replace the existing ones, but I asked the merchant's graphic designer to provide me with the new icons with a significant quality. Once I have received them, I will include them in this MR. Is this fine with you? |
@beratwallee That's great, thank you for doing that! And yes, let's do it all in this issue. |
Hi @Jacquesattaque. The merchant said they will remove the PostFinance Card and PostFinanace E-Finance from the market at the end of 2023, and only the PF Pay will be available. They asked me if we could keep the same logos until they will not ask us to remove them from this list. |
Hi @Jacquesattaque! Since the merchant wants to keep the other logos the same, can we proceed with this one? I solved the conflict in this branch. |
@beratwallee No problem, thanks! |
Why are you adding this icons?
I'm adding this icon because our merchant (PostFinance) wants to see the payment method listed.
Webpage: https://www.postfinance.ch/
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?
At your earliest convenience.