-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jenius and chinabank #945
Add jenius and chinabank #945
Conversation
@yanoandri can you optimize the icon using this website? Please make sure disable all of this. Reference: Step 5 https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md |
Done optimizing @candrasaputra. Hi @Jacquesattaque and @dannye0231 can you please review my PR, thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jacquesattaque, FYI i make the logo size smaller this time, can i have your review again? thanks in advance |
Hi @Jacquesattaque following up on this PR |
Hi @Jacquesattaque apology for the back and forth pushing to repo, i just test my svg in my local, would you mind to re-approve the workflow again? thanks and sorry for the inconvenience |
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?