-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qasitli #938
add qasitli #938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use our SVG template for the icon. You'll want to ensure there isn't a fill on the viewbox.
Hello @Jacquesattaque, the fill removed. |
@ahmada3mar The icon looks good. Please clear the automated check failures. |
@Jacquesattaque i could not clear the failure checks, any advice ? |
@adeniyiao May you have a look? |
@Jacquesattaque sorry, it's my bad. i had a misunderstanding. All checks have passed, can you check again please ? |
All looks good, thanks! |
Hello @Jacquesattaque, When will this PR merged ? |
@ahmada3mar We do a monthly release, typically on the first Wednesday of the month. Our next release is tentatively scheduled for Wednesday, November 1. |
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?