-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hsbc uk icon #1230
base: master
Are you sure you want to change the base?
Hsbc uk icon #1230
Conversation
HSBC UK version icon
fix typo
fix title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just reduce file size by running to through SVGO https://jakearchibald.github.io/svgomg/
svgomg reduced file size
fix svgo
fix svgo
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check and approve
Hi @payeverdev , are you able to resolve the conflict being flagged? Step 1: From your project repository, check out a new branch and test the changes. git checkout -b payeverworldwide-hsbc_uk_icon master git checkout master |
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
We are working on behalf of HSBC UK and they provided us the new logo, as a requirement to submit the HSBC UK bank transfer payment app within the Shopify Platform.
The provided logo:
What's the expected date of this change to deploy on Shopify?
As soon as possible