Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shopify-money version to >= 2.0 in gemspec. #387

Merged
merged 1 commit into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ PATH
builder (>= 2.1.2, < 4.0.0)
i18n (>= 0.6.6)
nokogiri (>= 1.8.5)
shopify-money (~> 2.0)
shopify-money (>= 2.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -221,7 +221,7 @@ GEM
rubyntlm (0.6.5)
base64
securerandom (0.3.1)
shopify-money (2.2.2)
shopify-money (3.0.0)
stringio (3.1.1)
test-unit (3.6.2)
power_assert
Expand Down
15 changes: 1 addition & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
> [!CAUTION]
> [!CAUTION]
> This gem is not actively maintained, and many of the integrations have not been updated in years. It is deprecated at Shopify, and should not be used.

# Offsite Payments
Expand Down Expand Up @@ -40,19 +40,6 @@ Or, if you're using Bundler, just add the following to your Gemfile:

gem 'offsite_payments'

### Money gem dependency

At the moment, `offsite_payments` gem depends on `Money` object, which was previously included by default. Since Shopify
released their own `shopify-money` gem. Because `offsite_payments` does not impose which one of those gems should be
included into your gem file, as long as one of them is included.


- For [ruby money gem](https://github.com/RubyMoney/money) add `gem 'money'` to your `Gemfile`;
- For [Shopify money gem](https://github.com/Shopify/money) add `gem 'shopify-money', require: 'money'` in your `Gemfile`.

It's important to note that either of those Money gems would need to be added to your `Gemfile` before the `offsite_payments`
one.

[API documentation](http://www.rubydoc.info/github/activemerchant/offsite_payments/master).

## Supported Integrations
Expand Down
2 changes: 1 addition & 1 deletion offsite_payments.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |s|

s.metadata['allowed_push_host'] = "https://rubygems.org"

s.add_dependency('shopify-money', '~> 2.0')
s.add_dependency('shopify-money', '>= 2.0')
s.add_dependency('activesupport', '>= 7.2.0')
s.add_dependency('i18n', '>= 0.6.6')
s.add_dependency('builder', '>= 2.1.2', '< 4.0.0')
Expand Down
Loading