CommerceHub: Update merchantInvoiceNumber & merchantTransactionId #5374
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
update_commerce_hub_merchant_invoice_number
branch
3 times, most recently
from
5935cc6 to
bbf2885
Compare
|
@sinourain can I have a re-review? I made some changes to the PR |
Update merchantTransactionId to be a random number and merchantInvoiceNumber to be the order_id. Remove account_verification, primary_transaction_type and merchant_invoice_number since they are not in use. Remote 36 tests, 97 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.2222% passed
almalee24
force-pushed
the
update_commerce_hub_merchant_invoice_number
branch
from
bbf2885 to
dfee2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update merchantTransactionId to be a random number and merchantInvoiceNumber to be the order_id. Remove account_verification, primary_transaction_type and merchant_invoice_number since they are not in use.
Remote 36 tests, 97 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.2222% passed