RedsysRest: Improve authorization from in Redsys #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ---------------- This enhance the authorization from method to include the 3DS case. [SER-1553](https://spreedly.atlassian.net/browse/SER-1553) Unit Tests ---------------- Finished in 0.03838 seconds. 28 tests, 124 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests ---------------- Finished in 41.53788 seconds. 29 tests, 111 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.5517% passed Rubocop ---------------- 806 files inspected, no offenses detected
Buitragox
reviewed
Dec 19, 2024
| # Need to get updated for 3DS support | ||
| [response[:ds_order], response[:ds_amount], response[:ds_currency]].join('|') | ||
| def authorization_from(response, post, options) | ||
| # Needed update for 3DS support |
There was a problem hiding this comment.
Does this comment mean that it still needs an update? Can the comment be deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enhance the authorization from method to include the 3DS case.
SER-1553
Unit Tests
Finished in 0.03838 seconds.
28 tests, 124 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote Tests
Finished in 41.53788 seconds.
29 tests, 111 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.5517% passed
Rubocop
806 files inspected, no offenses detected