Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvei: Update AFT request #5364

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Nuvei: Update AFT request #5364

merged 2 commits into from
Dec 12, 2024

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-1543

This commit update the AFT request to support non-domestic AFT

Unit test

Finished in 1.325061 seconds.

28 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

21.13 tests/s, 111.69 assertions/s

Remote test

Finished in 116.599139 seconds.

42 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

0.36 tests/s, 1.17 assertions/s

Rubocop

806 files inspected, no offenses detected

Description
-------------------------
[SER-1543](https://spreedly.atlassian.net/browse/SER-1543)

This commit update the AFT request to support non-domestic AFT

Unit test
-------------------------

Finished in 1.325061 seconds.

28 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

21.13 tests/s, 111.69 assertions/s

Remote test
-------------------------

Finished in 116.599139 seconds.

42 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

0.36 tests/s, 1.17 assertions/s

Rubocop
-------------------------

806 files inspected, no offenses detected
@javierpedrozaing javierpedrozaing force-pushed the SER-1543-Nuvei_non_domestic_aft branch from 783c6e0 to df3c92c Compare December 10, 2024 15:30
@javierpedrozaing javierpedrozaing marked this pull request as ready for review December 10, 2024 15:47
Copy link
Collaborator

@gasb150 gasb150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small comments to your consideration.

test/remote/gateways/remote_nuvei_test.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/nuvei.rb Show resolved Hide resolved
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naashton naashton merged commit 1dd6531 into master Dec 12, 2024
5 checks passed
@naashton naashton deleted the SER-1543-Nuvei_non_domestic_aft branch December 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants