OPPS-225 Worldpay Idempotency key fix #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherreraa
requested review from
sinourain,
Buitragox,
rubenmarindev and
almalee24
Buitragox
suggested changes
Dec 4, 2024
There was a problem hiding this comment.
Couple of things to fix. I also think it may be worth it to make a test that checks that it's actually changing the idempotency key between requests. Maybe something similar to the test test_optional_idempotency_key_header (that test is also missing an assert_equal, it's just comparing strings with ==).
https://github.com/activemerchant/active_merchant/blob/master/test/unit/gateways/worldpay_test.rb#L1505
jherreraa
force-pushed
the
OPPS-225_Worldpay_Idempotency_key_fix
branch
from
6973ba3 to
c35f701
Compare
Buitragox
approved these changes
Dec 4, 2024
jherreraa
force-pushed
the
OPPS-225_Worldpay_Idempotency_key_fix
branch
from
c35f701 to
9191189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests
Finished in 0.418613 seconds.
138 tests, 756 assertions, 0 failures, 0 errors,
0 pendings, 0 omissions, 0 notifications
100% passed
Remote Tests
Finished in 118.498554 seconds.
117 tests, 500 assertions, 0 failures, 0 errors,
0 pendings, 0 omissions, 0 notifications
100% passed