Hi Pay: Don't add 3ds when :three_ds_2 is missing #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buitragox
requested review from
a team,
sinourain,
jherreraa and
rubenmarindev
almalee24
approved these changes
Dec 4, 2024
Description ------------------------- When `:execute_threed` was present but `:three_ds_2` wasn't, it would cause an error. This fix makes it return early when `:three_ds_2` is missing. Unit tests ------------------------- 6120 tests, 80841 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote tests ------------------------- 20 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ------------------------- 803 files inspected, no offenses detected
Buitragox
force-pushed
the
OPPS-41_hi_pay_3ds2_error
branch
from
b775560 to
0c35067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
:execute_threedwas present but:three_ds_2wasn't, it would cause an error. This fix makes it return early when:three_ds_2is missing.Relevant docs:
Unit tests
6120 tests, 80841 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote tests
20 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Rubocop
803 files inspected, no offenses detected