Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldpay: Fix stored credentials unscheduled reason type #5352

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Buitragox
Copy link
Collaborator

Description

Unscheduled reason type should be sent in customer and merchant initiated transactions, except when it's a customer initiated transaction and usage=USED.

Unit tests

6119 tests, 80834 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote tests

114 tests, 489 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.3684% passed

Failures not related to changes.

Rubocop

803 files inspected, no offenses detected

@Buitragox Buitragox requested a review from a team December 2, 2024 14:29
Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of small suggestions: the branch name could be include the gateway name and in the ticket description please add the Spreedly reference with the ticket URL to Jira

Description
-------------------------
Unscheduled reason type should be sent in customer and merchant
initiated transactions, except when it's a customer initiated
transaction and usage=USED.

Unit tests
-------------------------
6119 tests, 80834 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote tests
-------------------------
114 tests, 489 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.3684% passed

Failures not related to changes.

Rubocop
-------------------------
803 files inspected, no offenses detected
@Buitragox Buitragox force-pushed the OPPS-230_fix_stored_credentials_reason branch from 798f06c to 80f1d1c Compare December 4, 2024 17:38
@Buitragox Buitragox merged commit 80f1d1c into master Dec 4, 2024
5 checks passed
@Buitragox Buitragox deleted the OPPS-230_fix_stored_credentials_reason branch December 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants