Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree: Account for BraintreeError #5346

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

almalee24
Copy link
Contributor

Take into account Braintree::ErrorResult for add_bank_account_to_customer to prevent NoMethodError

Unit:
108 tests, 231 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote:
123 tests, 662 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

@almalee24 almalee24 requested a review from a team November 25, 2024 21:54
@almalee24 almalee24 marked this pull request as ready for review November 25, 2024 21:54
Copy link
Collaborator

@jherreraa jherreraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@almalee24 almalee24 force-pushed the update_bank_account_nonce_response branch from d9606a5 to 2fe6ccb Compare December 4, 2024 16:32
Take into account Braintree::ErrorResult for add_bank_account_to_customer
to prevent NoMethodError

Unit:
108 tests, 231 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
123 tests, 662 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@almalee24 almalee24 merged commit 2fe6ccb into master Dec 4, 2024
5 checks passed
@almalee24 almalee24 deleted the update_bank_account_nonce_response branch December 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants