Litle: Omit checkNum when nil #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carrigan
approved these changes
Aug 11, 2020
ACH transactions in which the `checkNum` was `nil` were previously sending an empty `checkNum` node, which caused failures against the Litle gateway. This adds a check so that the `checkNum` node is created only when there is a value for this field. ECS-1350 Unit: 46 tests, 201 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 43 tests, 188 assertions, 13 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 69.7674% passed Many remote tests are currently failing [due to previously noted changes to the gateway's responses](#3618). All unit tests: 4544 tests, 72251 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
leila-alderman
force-pushed
the
ECS-1350_litle_checknum
branch
from
002586d to
06873c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACH transactions in which the
checkNumwasnilwere previouslysending an empty
checkNumnode, which caused failures against theLitle gateway.
This adds a check so that the
checkNumnode is created only when thereis a value for this field.
ECS-1350
Unit:
46 tests, 201 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
43 tests, 188 assertions, 13 failures, 0 errors, 0 pendings, 0
omissions, 0 notifications
69.7674% passed
Many remote tests are currently failing due to previously noted
changes to the gateway's responses.
All unit tests:
4544 tests, 72251 assertions, 0 failures, 0 errors, 0 pendings, 0
omissions, 0 notifications
100% passed