Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep memory support in VectorStore #2594

Merged
merged 116 commits into from
Oct 3, 2023
Merged

Deep memory support in VectorStore #2594

merged 116 commits into from
Oct 3, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Sep 14, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR integrates Deep Memory into DeepLake VectorStore. For this I've done the following:

  1. implemented DeepMemory Backend client that directly sends requests to Deep Memory API.
  2. Refactored code, so that now VectorStore can be imported directly from deeplake, like from deeplake import VectorStore
  3. Added a Vectorstore factory, as deep memory vectorstore needs a bit different implementation
  4. There are still some parts that I am going to Adress in the next PRs, most of them I commented with TODOs

Things to be aware of

Things to worry about

Additional Context

@adolkhan adolkhan marked this pull request as draft September 14, 2023 08:47
deeplake/core/vectorstore/deep_memory.py Outdated Show resolved Hide resolved
deeplake/core/vectorstore/deep_memory.py Outdated Show resolved Hide resolved
deeplake/client/client.py Outdated Show resolved Hide resolved
Copy link
Member

@davidbuniat davidbuniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add full test coverage

deeplake/client/client.py Outdated Show resolved Hide resolved
docs/source/Deep-Memory.rst Outdated Show resolved Hide resolved
docs/source/Deep-Memory.rst Outdated Show resolved Hide resolved
docs/source/Deep-Memory.rst Show resolved Hide resolved
docs/source/Deep-Memory.rst Outdated Show resolved Hide resolved
docs/source/Deep-Memory.rst Show resolved Hide resolved
@adolkhan adolkhan requested a review from ProgerDav October 3, 2023 06:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

96.2% 96.2% Coverage
2.2% 2.2% Duplication

@tatevikh tatevikh merged commit 178e28e into main Oct 3, 2023
22 of 26 checks passed
@tatevikh tatevikh deleted the deep_memory branch October 3, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-tests Trigger Full versioned OS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants