Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2405] Add ability to change htype #2590

Merged
merged 11 commits into from
Sep 14, 2023
Merged

[AL-2405] Add ability to change htype #2590

merged 11 commits into from
Sep 14, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • LHS is limited to "generic" and "image".
  • RHS is limited to "image", "class_label", "bbox", "bbox.3d", "embedding", "binary_mask", "segment_mask", "instance_label", "keypoints_coco" and "point".

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 97.14% and project coverage change: -2.47% ⚠️

Comparison is base (424c4e0) 83.97% compared to head (1eba9b1) 81.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   83.97%   81.50%   -2.47%     
==========================================
  Files         224      224              
  Lines       24643    24674      +31     
==========================================
- Hits        20693    20110     -583     
- Misses       3950     4564     +614     
Flag Coverage Δ
unittests 81.50% <97.14%> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/dataset/deeplake_query_tensor.py 89.18% <66.66%> (-0.63%) ⬇️
deeplake/core/tensor.py 87.68% <100.00%> (+0.50%) ⬆️
deeplake/util/exceptions.py 83.27% <100.00%> (-0.49%) ⬇️
deeplake/util/htype.py 93.22% <100.00%> (ø)

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deeplake/api/tests/test_api.py Show resolved Hide resolved
deeplake/core/tensor.py Show resolved Hide resolved
deeplake/htype.py Show resolved Hide resolved
deeplake/htype.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

98.8% 98.8% Coverage
0.0% 0.0% Duplication

@FayazRahman FayazRahman merged commit 3401ae1 into main Sep 14, 2023
10 of 12 checks passed
@FayazRahman FayazRahman deleted the fy_change_htype branch September 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants