Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataloader close #2589

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Remove dataloader close #2589

merged 3 commits into from
Sep 8, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Sep 7, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

due to api changes on libdeeplake side remove _dataloader.close()

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (06008ad) 83.94% compared to head (ec35c70) 83.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files         224      224           
  Lines       24504    24507    +3     
=======================================
+ Hits        20570    20573    +3     
  Misses       3934     3934           
Flag Coverage Δ
unittests 83.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/enterprise/dataloader.py 81.84% <100.00%> (+1.13%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@levongh levongh added the full-tests Trigger Full versioned OS tests label Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@levongh levongh merged commit ce8fad9 into main Sep 8, 2023
31 of 36 checks passed
@levongh levongh deleted the remove_dataloader_close branch September 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-tests Trigger Full versioned OS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants