Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled linting in build process #2586

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Re-enabled linting in build process #2586

merged 6 commits into from
Sep 8, 2023

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Sep 7, 2023

🚀 🚀 Pull Request

Impact

  • Build logic

Description

Linting has not ran like it should be. Re-enabled it.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 89.33% and project coverage change: -0.04% ⚠️

Comparison is base (78109ea) 83.93% compared to head (7707ef8) 83.89%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
- Coverage   83.93%   83.89%   -0.04%     
==========================================
  Files         224      224              
  Lines       24504    24526      +22     
==========================================
+ Hits        20567    20576       +9     
- Misses       3937     3950      +13     
Flag Coverage Δ
unittests 83.89% <89.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/partial_sample.py 93.33% <ø> (ø)
deeplake/core/vectorstore/deeplake_vectorstore.py 97.50% <ø> (ø)
...ke/core/vectorstore/vector_search/filter/filter.py 100.00% <ø> (ø)
...ectorstore/vector_search/indra/search_algorithm.py 88.88% <ø> (ø)
deeplake/integrations/mmdet/mmdet_utils.py 0.00% <0.00%> (ø)
deeplake/util/connect_dataset.py 92.45% <ø> (ø)
deeplake/util/from_tfds.py 0.00% <0.00%> (ø)
deeplake/core/chunk_engine.py 92.97% <63.63%> (-0.20%) ⬇️
deeplake/core/tensor.py 87.18% <66.66%> (-0.10%) ⬇️
deeplake/util/storage.py 86.08% <93.33%> (+0.12%) ⬆️
... and 16 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@nvoxland nvoxland requested a review from levongh September 7, 2023 19:52
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

87.9% 87.9% Coverage
0.0% 0.0% Duplication

@nvoxland nvoxland merged commit d487171 into main Sep 8, 2023
13 of 14 checks passed
@nvoxland nvoxland deleted the re-enable-linting branch September 8, 2023 15:26
@nvoxland nvoxland changed the title Re-enabled linting Re-enabled linting in build process Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants