-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support i18n #170
base: master
Are you sure you want to change the base?
support i18n #170
Conversation
Thank you for your contribution. Sounds good! |
@syguer Thanks for the review. The point out you've made is fixed with the next commit. About the document/testing, I'll try. Document is relatively easy, whereas the test it might take some time for me to figure out how to setup... (all the locale setup usually made by rails, I find it not obvious how to write tests...) |
README is updated. |
It looks nice work to me 👏 I would like to know why this pull request is not merged. |
From where I remember, I was asked to write tests. I would be glad if anyone can help... |
This PR makes ActiveHash support i18n if
I18n
is available.With this fix, model's model_name will be configurable by locale file, for example: