Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename worker_id to executor_id #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename worker_id to executor_id #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub-executor-worker/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: datahub-executor-worker
description: A Helm chart for datahub-executor-worker
type: application
version: 0.0.8
version: 0.0.9
appVersion: 0.0.1
maintainers:
- name: DataHub
Expand Down
4 changes: 2 additions & 2 deletions charts/datahub-executor-worker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
# Create secret object with GMS access token. Note that secret name and key must match those in values file
$ kubectl create secret generic datahub-access-token-secret --from-literal=datahub-access-token-secret-key=<DATAHUB-ACCESS-TOKEN>

# Deploy executor with worker ID "remote" and GMS URL "https://company.acryl.io/gms"
# Deploy executor with executor ID "remote" and GMS URL "https://company.acryl.io/gms"
$ helm install \
--set global.datahub.executor.worker_id="remote" \
--set global.datahub.executor.executor_id="remote" \
--set global.datahub.gms.url="https://company.acryl.io/gms" \
default ./charts/datahub-executor-worker
```
4 changes: 3 additions & 1 deletion charts/datahub-executor-worker/templates/workload.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,10 @@ spec:
key: {{ ((.Values.global.datahub).gms).secretKey }}
- name: DATAHUB_EXECUTOR_MODE
value: "worker"
{{- with .Values.global.datahub.executor }}
- name: DATAHUB_EXECUTOR_WORKER_ID
value: {{ .Values.global.datahub.executor.worker_id | quote }}
value: {{ .executor_id | default .worker_id | quote }}
{{- end }}
- name: DATAHUB_EXECUTOR_INGESTION_MAX_WORKERS
value: {{ .Values.global.datahub.executor.ingestions.max_workers | quote }}
- name: DATAHUB_EXECUTOR_INGESTION_SIGNAL_POLL_INTERVAL
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub-executor-worker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ global:
secretKey: datahub-access-token-secret-key
url: https://datahub.acryl.io/gms
executor:
worker_id: "remote"
executor_id: "remote"
ingestions:
max_workers: 4
signal_poll_interval: 2
Expand Down
Loading