Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: widen spacy requirements #22

Merged
merged 2 commits into from
Jun 27, 2024
Merged

feat: widen spacy requirements #22

merged 2 commits into from
Jun 27, 2024

Conversation

cburroughs
Copy link
Contributor

spacy is a large library with many transitive dependencies. Having a tight bound makes resolving datahub-ingests with wider Python ecosystems difficult.

@cburroughs
feat: widen spacy requirements
7429b73 
spacy is a large library with many transitive dependencies.  Having a
tight bound makes resolving datahub-ingests with wider Python
ecosystems difficult.
@cburroughs
Copy link
Contributor Author

Notes:

  • The old constraint had the odd property of allowing 3.5.0, but not 3.5.1
  • I ran the test for over an hour without error, but they didn't complete. I'm unsure about the expected runtime.

@cburroughs
Copy link
Contributor Author

polite bump

hsheth2
hsheth2 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes

@mayurinehate mayurinehate merged commit 4649762 into acryldata:main Jun 27, 2024
2 checks passed
@cburroughs
Copy link
Contributor Author

Thank you!

@cburroughs
Copy link
Contributor Author

Sorry for the re-bump! The original impetus for this was the acryl-datahub-classify==0.0.10 pin in https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/setup.py . Would you mind doing a release of acryl-datahub-classify (so that metadata-ingestion can be updated) at a convenient point in the near future?

@hsheth2
Copy link
Contributor

hsheth2 commented Jul 2, 2024

@cburroughs I've cut v0.0.11 - should be available in a few

@cburroughs cburroughs mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

@mardikark-gslab mardikark-gslab Awaiting requested review from mardikark-gslab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cburroughs @hsheth2 @mayurinehate