fix(retries): move handle failure code outside of while loop #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtekal
reviewed
Sep 6, 2024
| logger.error( | ||
| f"Failed to process event after {self._retry_count} retries. event type: {enveloped_event.event_type}, pipeline name: {self.name}. Handling failure..." | ||
| ) | ||
| logger.error( |
There was a problem hiding this comment.
This is a good catch. Showing the error once outside the loop and incrementing the failure count.
Thank you Nate.
hsheth2
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle failure code is in the while loop, so after a single failure it will run the _handle_failure function. The retries will still happen if the
failure_modeis set toCONTINUE, but if it's set toTHROWit will throw an exception after the first failure. With these lines outside of the loop, it will still log when an attempt fails and then once all retries are exhausted it will print the actual failure message and throw and exception if set toTHROWmode.