DG-28970 | Add backup_requests method #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 19, 2024 20:48
nishatbaig
approved these changes
Jul 30, 2024
lib/sfrest/backup.rb
Outdated
| def execute_rest_backup(rconn, site_nid, name, components) | ||
| payload = { | ||
| 'label' => name, | ||
| 'callback_url' => 'http://www.example.com', |
There was a problem hiding this comment.
Do we care about callback_url? Afaik, that's optional.
There was a problem hiding this comment.
No we dont care about it, just for testing sake I added it.
There was a problem hiding this comment.
Can we remove it then? We shouldn't have the factory call unwanted sites.
Raksha-Bharuka
approved these changes
Dec 12, 2024
glitchinfinity
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Site Factory API 'components' options not working as expected Fix with integration testing