Orca 559 : Compatibility with PHPunit 10 #420
Conversation
secretsayan
commented
Aug 3, 2023
•
secretsayan
commented
- Coverage was enabled for all tests, as tests were failing due to a warning saying "coverage driver is not available" , may be we should resolve "failonwarning" settings of phpunit
secretsayan
added
enhancement
There was a problem hiding this comment.
Looks good in general, with a few suggestions. (I hope there was a script to change all those data provider signatures to static for you!)
As to the removal of PHPLOC, that's a functional change that should have a separate PR. No one looking at this PR would say, "Hmm, Compatibility with PHPunit 10. I'd better make sure it didn't change the CLI API." Also, when you announce the change, you'll want to link to a PR where it and it only is discussed.
tests/Domain/Composer/Version/DrupalCoreVersionResolverTest.php
Outdated
Show resolved
Hide resolved
|
@TravisCarden : Please review this PR, I have deprected |
secretsayan
force-pushed
the
orca-559
branch
3 times, most recently
from
a4c8ff0 to
ffee917
Compare
|
@TravisCarden Please review this PR |
There was a problem hiding this comment.
I'm gonna start being a little rougher on my reviews, @secretsayan. 😉 Please take this one back and look it over again before I review it. After a quick skim, I see some fairly basic oversights.
secretsayan
force-pushed
the
orca-559
branch
2 times, most recently
from
c288f2c to
a8b0f26
Compare
This reverts commit ea3bc73.
Co-authored-by: Travis Carden <[email protected]>
This reverts commit 44de03a.
This reverts commit ad98f0c.
There was a problem hiding this comment.
Looks good, @secretsayan! I left one question that you can mark resolved or address based on the answer. Merge at your pleasure. 🙂
