Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPD-7592 keep standard tags when updating #290

Open
wants to merge 1 commit into
base: proxy-cli-hook-aws-v2
Choose a base branch
from

Conversation

lethanh273
Copy link

@lethanh273 lethanh273 commented Nov 30, 2022

Change: patch
Purpose: maintenance

Manual testing:
in cloud-database-api folder, replace moonshot with 

  gem 'moonshot',      git: '[email protected]:lethanh273/moonshot.git',      ref: 'master' 

bundle update moonshot 
cd network 
bundle exec moonshot update -n dev-ltt
rm cloud_formation/cdb-network.json if need to
The stack tags will be kept as they are.

Copy link
Contributor

@kaushik kaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of cloud data specific information should be in moonshot. This is an independent gem used to manage cloud formation deployments.

@lethanh273 lethanh273 force-pushed the cpd-7592-keep-standard-tags branch from 73d6131 to aa6cc33 Compare December 2, 2022 01:01
Change: patch
Purpose: maintenance
@lethanh273 lethanh273 force-pushed the cpd-7592-keep-standard-tags branch from aa6cc33 to 11180be Compare December 2, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants