Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCH-6902: Remove Amplitude from CHUC #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LCH-6902: Remove Amplitude from CHUC #46

wants to merge 2 commits into from
+25 −288

Conversation

benclark
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

narendradesai
narendradesai requested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@narendradesai narendradesai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, just one question: Any specific reason for updating phpunit.xml? NVM, got it.

Although we need to fix failing test cases for php 8.2

@benclark
Copy link
Contributor Author

Overall looks fine, just one question: Any specific reason for updating phpunit.xml? NVM, got it.

Yeah, I was just trying to pass the tests and saw that warning message about the schema. It didn't end up helping, as you saw. If you'd like, I can revert that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendradesai narendradesai narendradesai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclark @narendradesai