Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 9 compatibility #81

Open
wants to merge 1 commit into
base: 8.x-dev
Choose a base branch
from
Open

Drupal 9 compatibility #81

wants to merge 1 commit into from

Conversation

stevenlafl
Copy link

Drupal 9 requires Symfony 4. We are currently locked at Symfony 3.

 - Conclusion: don't install acquia/acsf-tools 9.0.0
    - drupal/core-recommended 9.0.0 requires symfony/yaml v4.4.9 -> satisfiable by symfony/yaml[v4.4.9].

This updates the requirement to use Symfony 4.

sdelbosc added a commit to sdelbosc/acsf-tools that referenced this pull request Jun 30, 2020
sdelbosc added a commit to sdelbosc/acsf-tools that referenced this pull request Jun 30, 2020
sdelbosc added a commit to sdelbosc/acsf-tools that referenced this pull request Jun 30, 2020
sdelbosc added a commit to sdelbosc/acsf-tools that referenced this pull request Jun 30, 2020
@sdelbosc
Copy link
Contributor

sdelbosc commented Jun 30, 2020

Thanks @stevenlafl.
Would you mind confirming

  • that you got a chance to successfully test the change you raised on that PR
  • whether or not your project uses Acquia BLT and if which version
  • whether or not your project uses config from acsf_tools_config.yml

@nikunjkotecha
Copy link

IMO we should close this in favor of #119

@sdelbosc
Copy link
Contributor

sdelbosc commented Jan 5, 2021

Would be better to tackle this in a similar manner as what had been done with #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants