Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3596: Remove axelerant/drupal-quality-checker plugin. #1762

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,18 @@
},
"require-dev": {
"acquia/coding-standards": "^1.0",
"axelerant/drupal-quality-checker": "^1.1",
"dealerdirect/phpcodesniffer-composer-installer": "*",
"drupal/coder": "^8.3.7",
"drupal/core-composer-scaffold": "^9.0.0 || ^10",
"drupal/core-dev": "^9 || ^10",
"ergebnis/composer-normalize": "^2.31.0",
"friendsoftwig/twigcs": "^4.0 || ^5.0 || ^6.0",
"mglaman/drupal-check": "^1.4",
"oomphinc/composer-installers-extender": "^1.1 || ^2",
"php-parallel-lint/php-parallel-lint": "^1.2",
"phpcompatibility/php-compatibility": "^9.0",
"phpmd/phpmd": "^2.8",
"phpro/grumphp-shim": "^1.0.0",
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/phpunit": "^9.4.0",
"weitzman/drupal-test-traits": "^2"
Expand Down
128 changes: 2 additions & 126 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

51 changes: 51 additions & 0 deletions grumphp.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
parameters:
git_dir: .
bin_dir: vendor/bin
grumphp:
ascii:
failed: vendor/axelerant/drupal-quality-checker/resources/grumpy.txt
succeeded: vendor/axelerant/drupal-quality-checker/resources/happy.txt
tasks:
phplint: ~
yamllint: ~
composer: ~
jsonlint: ~
twigcs:
path: 'web'
ruleset: 'FriendsOfTwig\Twigcs\Ruleset\Official'
exclude:
- core
- modules/contrib
- themes/contrib
- profiles/contrib
phpcpd:
directory: ['./web/modules/custom']
phpcs:
standard:
- phpcs.xml.dist
ignore_patterns:
- .github
- .gitlab
- /config/
- /drush/
- /web/robots.txt
- /web/sites/default/
- bower_components
- node_modules
- /vendor
triggered_by:
- php
- module
- inc
- install
- test
- profile
- theme
- css
- info
- txt
phpmd:
whitelist_patterns:
- /^web\/modules\/custom\/(.*)/
ruleset: ['phpmd.xml.dist']
triggered_by: ['php']
43 changes: 43 additions & 0 deletions phpmd.xml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?xml version="1.0"?>
<ruleset name="PHPMD ruleset for Drupal"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
<description>
Custom ruleset for Drupal projects at Axelerant
</description>

<!-- Import common rulesets -->
<rule ref="rulesets/codesize.xml"/>
<rule ref="rulesets/design.xml"/>
<rule ref="rulesets/naming.xml"/>
<rule ref="rulesets/unusedcode.xml"/>

<!-- Import entire clean code rule set, modify StaticAccess rule -->
<rule ref="rulesets/cleancode.xml">
<exclude name="StaticAccess"/>
<exclude name="MissingImport"/>
</rule>
<rule ref="rulesets/cleancode.xml/StaticAccess">
<properties>
<property name="exceptions">
<value>
\DateTime,
\DateInterval,
\DateTimeZone,
\Drupal\Component\Plugin\Factory\DefaultFactory,
\Drupal\Component\Utility\Html,
\Drupal\Component\Utility\UrlHelper,
\Drupal\Core\Access\AccessResult,
\Drupal\Core\Url,
\Drupal\Core\Cache\Cache,
\Drupal\Core\Render\Element,
\Drupal\Core\Render\Element\Checkboxes,
\Drupal\Core\Annotation\Action,
\Drupal\Core\Site\Settings,
</value>
</property>
</properties>
</rule>
</ruleset>
Loading