feature/139-refactoring #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eschltz @drpaulralph first PR for refactoring! |
|
I tested some different checklist combinations and everything still seems to be working fine. |
… feat/139-refactoring
|
Hello Erin, Hello Prof. Ralph, Sorry, it took a while to get to it. I was having some trouble with Ruby on my new Mac, so setting up the project locally took some time. But the changes are now done and can be reviewed again! @eschltz, can you try some combinations and let me know if everything is working fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step of the refactoring, I broke down the read_standards file into 12 smaller files/modules based on logical grouping.
I tested it on my local machine, but it would be good if Erin could also test out the scenarios for submission checklist generation, as I might have missed some corner cases.
Once this is merged, I can improve readability and documentation and better annotate the regular expressions.