Add basic proxy support #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudef
force-pushed
the
feature/basic-http-proxy
branch
3 times, most recently
from
cdeec62 to
8c7d991
Compare
|
Hi @Cloudef, thanks for the PR. Code looks really good! I probably need to run these through the autobahn test again to make sure everything is kosher. Would be cool to test it behind a proxy as well. As soon as I get a chance to do that, I will get back to you. |
|
Thanks, I used squidman for testing the proxy. |
Cloudef
force-pushed
the
feature/basic-http-proxy
branch
2 times, most recently
from
c0a47c1 to
bc94812
Compare
|
I updated the PR to fix some issues with old implementation. Mainly SSL handover failed if proxy responses were not fully read from stream, and authentication needing dialog due to it being impossible to get password for proxy set in system settings from system keychain on iOS. |
Cloudef
force-pushed
the
feature/basic-http-proxy
branch
from
bc94812 to
bf83345
Compare
Support proxy configuration for proxies that support HTTP tunnel feature. Only basic authentication is implemented. SSL handover after CONNECT TCP tunneling, by making sure all incoming data from proxy is read before moving forward. Maximum proxy responses are limited to 10MiB. Go over this and the code will ignore anything proxy has to say.
Cloudef
force-pushed
the
feature/basic-http-proxy
branch
from
bf83345 to
a6643cd
Compare
|
I've used these changes with Charles proxy and everything just worked. Nice, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support proxy configuration for proxies that support HTTP tunnel feature.
Only basic authentication is implemented.