New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 404-error page #74

Merged

seanquiambao merged 2 commits into dev from AnPhu-D/Error-404-Page

Nov 13, 2024

Collaborator

AnPhu-D commented Nov 12, 2024 •

edited

Loading

Fix #35

Notes:

"uh oh!" text is 30px (instead of 32px as specified by figma) because preference for using tailwind preset over hardcoding font size
"uh oh!" line height is set to leading-loose (2) instead of leading-tight (1.25) to match appearance of figma file as opposed to raw values


          Implement 404-error page

1c15c54

AnPhu-D added the Ready to Review label

AnPhu-D self-assigned this

Collaborator Author

AnPhu-D commented Nov 12, 2024


          Switch h1/h2/p to div

9febbce

seanquiambao approved these changes

View reviewed changes

seanquiambao merged commit d89f205 into dev

5 checks passed

seanquiambao deleted the AnPhu-D/Error-404-Page branch

November 13, 2024 01:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to Review