Added profile header #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
khandrew1
requested changes
Oct 29, 2024
| }: HeaderProps) => { | ||
| return ( | ||
| <div className="mb-10 mt-7 flex max-w-full flex-row items-center gap-5 overflow-hidden"> | ||
| <img |
| <div className="max-h-full max-w-full"> | ||
| <div className="gap-x-1/2 gap-y-1/2 grid grid-cols-[30px_1fr] items-center"> | ||
| <Mail className="h-5 w-5" /> | ||
| <a |
There was a problem hiding this comment.
use next/link instead of a
| className="hidden h-40 w-1/6 rounded-xl object-cover md:block" | ||
| /> | ||
| <div className="flex max-h-full w-full max-w-full flex-col gap-1"> | ||
| <h1 className="text-3xl font-bold">{name}</h1> |
There was a problem hiding this comment.
using h1 directly like this messes with SEO.
should be able to use a <p> tag instead and i think text-3xl will keep it the same size.
…-GHub/Profile-Header
shahdivyank
approved these changes
Oct 29, 2024
shahdivyank
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to use react icons for the discord logo, added the header, and added a public folder to test out images. Also right now everything is blue.
Let me know if anything needs to be changed!