Hackinrish/button #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hackinrish
commented
Oct 22, 2024
•
hackinrish
commented
- Button that takes in a text prop and an onclick functon, function can be modified later for according use
- Closes Issue Create Button #8
jnalbert
reviewed
Oct 22, 2024
src/app/page.tsx
Outdated
| @@ -1,8 +1,6 @@ | |||
| const Home = () => { | |||
| return ( | |||
| <div className="flex h-screen w-screen items-center justify-center"> | |||
There was a problem hiding this comment.
Can you revert this change so it still says hello world
src/components/Button.tsx
Outdated
|
|
||
| interface ButtonProps { | ||
| text: string; | ||
| link: string; |
There was a problem hiding this comment.
instead of passing in a link can you pass in an arrow function here. For example it can be handleSubmit: () => void. Then this function should be called when the button component is clicked.
src/components/Button.tsx
Outdated
|
|
||
| const Button = ({ text, link }: ButtonProps) => { | ||
| return ( | ||
| <div className="rounded-md bg-blue-900 px-8 py-2 font-serif text-[vw] text-white"> |
There was a problem hiding this comment.
Instead of a div can we use the button component here. It's better for accessibility and makes more sense in this case.
jnalbert
reviewed
Oct 22, 2024
src/components/Button.tsx
Outdated
| return ( | ||
| <button | ||
| className="rounded-md bg-blue-900 px-8 py-2 font-serif text-[vw] text-white" | ||
| onClick={() => onClick(text)} |
There was a problem hiding this comment.
Suggested change
| onClick={() => onClick(text)} | |
| onClick={onClick} |
src/components/Button.tsx
Outdated
|
|
||
| interface ButtonProps { | ||
| text: string; | ||
| onClick: (params: string) => void; |
There was a problem hiding this comment.
remove the params from this function
Closed
shahdivyank
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.