fixed donate button #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
charleenschen
commented
Feb 3, 2024
charleenschen
commented
Closed
rfairooz
reviewed
Feb 7, 2024
src/components/donate/Donate.js
Outdated
| @@ -5,7 +5,7 @@ const Donate = () => { | |||
| return ( | |||
| <Link | |||
| href="#" | |||
| className="bg-green-600 text-white text-2xl font-bold text-decoration-line: underline flex justify-center items-center rounded-3xl min-w-fit px-4 min-h-fit py-1 hover:scale-110" | |||
| className="bg-hsp-green text-white text-[60px] font-urbanist font-black underline flex justify-center items-center rounded-[40.5rem] w-[364] h-[81] my-7 px-2.5 py-0 decoration-1 underline-offset-4 hover:scale-110" | |||
There was a problem hiding this comment.
so this is good! instead of hardcoding height and width, can you eye ball it and make min-w-fit and w-4/12 or something for the page. And also for text-[60px] make it text-3xl or anything that is closer to 60 px.
hsp-website.code-workspace
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
can you try pushing again? I think you pushed the workspace accidentally.
rfairooz
reviewed
Feb 18, 2024
src/components/donate/Table.js
Outdated
| @@ -1,7 +1,115 @@ | |||
| import React from "react"; | |||
|
|
|||
| const Table = () => { | |||
| return <div>Table</div>; | |||
| return ( | |||
There was a problem hiding this comment.
the table should not be part of your commit. Check and push again
src/components/donate/Donate.js
Outdated
| @@ -5,7 +5,7 @@ const Donate = () => { | |||
| return ( | |||
| <Link | |||
| href="#" | |||
| className="bg-green-600 text-white text-2xl font-bold text-decoration-line: underline flex justify-center items-center rounded-3xl min-w-fit px-4 min-h-fit py-1 hover:scale-110" | |||
| className="bg-hsp-green text-white text-6xl font-urbanist font-black underline flex justify-center items-center rounded-[40.5rem] min-w-fit h-20 my-7 px-2.5 py-0 decoration-1 underline-offset-4 hover:scale-110" | |||
There was a problem hiding this comment.
rounded-40.5 rem cannot be hard coded. Change to 2xl or whichever value matches the most.
rfairooz
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.