created footer #16
Merged
created footer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kellyma073
commented
Jan 19, 2024
kellyma073
commented
Closed
rfairooz
reviewed
Jan 20, 2024
src/components/Footer.js
Outdated
| return <div>Footer</div>; | ||
| return ( | ||
| <div className="bg-black flex w-full pl-6 pb-14 pt-28"> | ||
| <div className="grid grid-cols-11 text-white justify-between w-full "> |
There was a problem hiding this comment.
instead of 11 columns try use changing the width for each column to have it span more.
src/components/Footer.js
Outdated
| </div> | ||
| <div className="bg-white w-1 h-52 flex justify-start ml-16 mt-7"></div> | ||
| <div className="grid grid-cols-2 gap-10 space-x-2 text-5xl mt-7 cols-span-2"> | ||
| <FaInstagram /> |
There was a problem hiding this comment.
make all these links. For now, just include basic links later we will add hsp socials.
rfairooz
reviewed
Jan 23, 2024
src/components/Footer.js
Outdated
| </div> | ||
| <div className="grid grid-cols-2 text-5xl text-white h-5/6 hover:curson-pointer "> | ||
| <div className="flex justify-between flex-col items-center"> | ||
| <Link href="https://github.com/acm-ucr/hsp-website/pull/16/files"> |
There was a problem hiding this comment.
put a classname with text-white in each link. The links show up as blue now it should be white
added 4 commits
January 23, 2024 09:34
rfairooz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.