Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volunteer opportunites component #135

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

shirleyduong
Copy link
Collaborator

iPhone: hides photo

iPad:
image

Laptop/Desktop:
image

<Photo
image={VolunteerPhoto}
width={"w-1/2 lg: w-3/4"}
width=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a width prop
In the Photo component, add a default prop for width as an empty string (so that you don't need to pass in this prop when calling the function).

Also are you sure that you want to get rid of the width for this particular photo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenever I tried using width, it would make the photo smaller than I would like

@SafeDuck SafeDuck merged commit 77cca90 into dev Nov 19, 2024
5 checks passed
@SafeDuck SafeDuck deleted the shirleyduong/fixVolunteerComponent branch November 19, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Volunteer Opportunities component
2 participants