Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stanley/whyjoin #86

Merged
merged 4 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/home/Focus.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ import ArrowLink from "../ArrowLink";

const Focus = ({ title, description, link, icon }) => {
return (
<div className="flex flex-col items-center bg-blue-100 w-1/5">
<div className="relative flex flex-col items-center bg-blue-100 p-2">
<div className="flex justify-center text-3xl text-ewb-green my-2">
{icon}
</div>
<p className="font-bold text-2xl">{title}</p>
<p className="font-normal text-xl whitespace-normal text-center break-keep w-3/4">
<p className="font-bold text-2xl text-center py-2">{title}</p>
<p className="font-normal text-xl whitespace-normal text-center break-keep w-3/4 pt-2 pb-4">
{description}
</p>
<ArrowLink text="learn more" link={link} />
{link !== "" && <ArrowLink text="learn more" link={link} />}
</div>
);
};
Expand Down
32 changes: 31 additions & 1 deletion src/components/home/WhyJoin.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,35 @@
import Title from "../Title";
import { FOCUS } from "@/data/focus";
import Focus from "./Focus";
import Picture from "../Picture";
const WhyJoin = () => {
return <div>WhyJoin</div>;
return (
<div className="p-16 flex flex-col items-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is just for vertical padding, try py-16 and for the horizontal you can use width to style it so it can be more responsive.

<div className="absolute w-1/3 aspect-square bg-ewb-blue-100/40 rounded-full -translate-y-14" />
<Title subTitle="GET INVOLVED AND MAKE AN IMPACT!" title="WHY JOIN EWB" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go into the title component and add a z-10 to the className, because sometime the title is behind the circle

<div className="relative text-center pt-12 ml-72 mr-72 ">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of margin, try a fraction width like w-9/12

Engineers Without Borders at UCR currently hosts several projects,
professional development events, and club activities for members to
actively participate in. We highly encourage all students to broaden
their learning experience by participating in our organization
activities. We hope that through these activities, students will grow as
skilled professionals and leaders.
</div>
<div className="grid grid-cols-2 gap-4 my-12 mx-72">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do width instead of mx

{FOCUS.map((focus, index) => (
<Focus
index={index}
key={index}
title={focus.title}
description={focus.description}
icon={focus.icon}
link=""
/>
))}
</div>
<Picture picture="/images/CostaRica/CostaRica1.gif" />
</div>
);
};

export default WhyJoin;