Add Subtitle #29
Merged
Add Subtitle #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
allison-pham
commented
Oct 12, 2023
allison-pham
commented
Closed
menthy-wu
reviewed
Oct 13, 2023
src/app/page.js
Outdated
| const Home = () => { | ||
| return ( | ||
| <> | ||
| <Landing /> | ||
| <About /> | ||
| <WhyJoin /> | ||
| <Projects /> | ||
| <Subtitle /> |
There was a problem hiding this comment.
title = "Motivation" subtitle = "Rural communities are already disadvantaged socioeconomically"
src/components/Subtitle.jsx
Outdated
| const Subtitle = ({ title }) => { | ||
| return <div>Subtitle</div>; | ||
| import React from "react"; | ||
| const Subtitle = ({ title = "| Motivation" }) => { |
src/components/Subtitle.jsx
Outdated
| return <div>Subtitle</div>; | ||
| import React from "react"; | ||
| const Subtitle = ({ title = "| Motivation" }) => { | ||
| // const Subtitle = ({ title }) => { |
src/components/Subtitle.jsx
Outdated
| const Subtitle = ({ title = "| Motivation" }) => { | ||
| // const Subtitle = ({ title }) => { | ||
| const blueColor = "#1151D3"; | ||
| const greenColor = "#80C393"; |
src/components/Subtitle.jsx
Outdated
| const greenColor = "#80C393"; | ||
| return ( | ||
| <div> | ||
| <h2 style={{ color: blueColor }}>{title}</h2> |
There was a problem hiding this comment.
use p tag
add left border: border-l-4 border-ewb-green
use tailwind to color the text: text-ewb-blue-200
give a text size
src/components/Subtitle.jsx
Outdated
| return ( | ||
| <div> | ||
| <h2 style={{ color: blueColor }}>{title}</h2> | ||
| <p style={{ color: greenColor }}> |
There was a problem hiding this comment.
use tailwind className
give a text size
src/components/Subtitle.jsx
Outdated
| <div> | ||
| <h2 style={{ color: blueColor }}>{title}</h2> | ||
| <p style={{ color: greenColor }}> | ||
| Rural communities are already disadvantaged socioeconomically |
There was a problem hiding this comment.
use the subtitle prop {subtiotle}
menthy-wu
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.