title page #27
Closed
title page #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
inegishi
commented
Jan 14, 2025
inegishi
commented
stanleylew5
requested changes
Jan 15, 2025
src/components/title/Title.tsx
Outdated
| const Title: React.FC<TitleNameProps> = ({ text }) => { | ||
| return ( | ||
| <div className="relative mt-1 flex items-center justify-center"> | ||
| <div className="mr-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> |
There was a problem hiding this comment.
Suggested change
| <div className="mr-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> | |
| <div className="mr-4 mt-4 h-[.8vh] w-[20vw] bg-csa-green-100" /> |
use tailwind config colors ex: bg-csa-green-100
src/components/title/Title.tsx
Outdated
| </svg>{" "} | ||
| </div> | ||
|
|
||
| <div className="ml-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> |
There was a problem hiding this comment.
Suggested change
| <div className="ml-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> | |
| <div className="ml-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> |
same thing with the color thing here
src/components/title/Title.tsx
Outdated
| </svg>{" "} | ||
| </div> | ||
|
|
||
| <div className="ml-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> |
There was a problem hiding this comment.
Suggested change
| <div className="ml-4 mt-4 h-[.7vh] w-[20vw] bg-[#6F7765]" /> | |
| <div className="ml-4 mt-4 h-[.8vh] w-[20vw] bg-[#6F7765]" /> |
src/components/title/Title.tsx
Outdated
|
|
||
| <text | ||
| fill="#7C2413" | ||
| font-size="7vw" |
There was a problem hiding this comment.
Suggested change
| font-size="7vw" | |
| font-size="6.5vw" |
src/components/title/Title.tsx
Outdated
| > | ||
| <path | ||
| id="curve" | ||
| d="M50,150 Q200,30 350,150" |
There was a problem hiding this comment.
Suggested change
| d="M50,150 Q200,30 350,150" | |
| d="M50,150 Q200,10 370,150" |
src/components/title/Title.tsx
Outdated
There was a problem hiding this comment.
This is a component that is used multiple times so it should not be within it's own folder. It should be within src/components. Components that are restricted to their own pages will generally be in src/components/about and etc.
|
|
Open
inegishi
added
help wanted
|
|
stanleylew5
added
changes requested
and removed
help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.