Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): create all affiliation files #60

Merged
merged 17 commits into from
Jul 1, 2024
Merged

Conversation

PaleBluDot
Copy link
Member

@PaleBluDot PaleBluDot commented May 20, 2024


@PaleBluDot PaleBluDot self-assigned this May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for aclu-emails ready!

Name Link
🔨 Latest commit a116583
🔍 Latest deploy log https://app.netlify.com/sites/aclu-emails/deploys/6666462dd81c0f00088bdd2a
😎 Deploy Preview https://deploy-preview-60--aclu-emails.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaleBluDot PaleBluDot added the enhancement New feature or request label May 20, 2024
@PaleBluDot PaleBluDot marked this pull request as draft May 20, 2024 21:40
@PaleBluDot PaleBluDot requested a review from barsinister May 20, 2024 21:40
@PaleBluDot
Copy link
Member Author

PaleBluDot commented May 22, 2024

So far I have a-l updates complete and ready for testing.

So you will notice some signature headshots are using non ST URLs. I was going through the website to make sure they are all up to date. So if I added and image and a TODO: comment, we need to format the image using the Photoshop template and uploaded to ST.

Would be great if this is something that you and with the help of someone else do that by the time I am back and I can do an update of those once I am back. @barsinister

@PaleBluDot PaleBluDot marked this pull request as ready for review June 9, 2024 23:45
@PaleBluDot
Copy link
Member Author

@barsinister, so for this, it is only checking the data files. I did go through affiliates' websites to update the signatures to the latest.

So for this pull the lastest commit on this branch, switch to this branch and locally run npm run build. This will build the files locally. You then want to take the file dist/data/dataLoader.min.json and save it to the Sailthru include. Make sure you are testing Dev environment only. Please NEVER save this to prod until the PR has been signed off and closed.

Copy link
Collaborator

@barsinister barsinister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data is all good and loading for all affiliates.

@PaleBluDot PaleBluDot merged commit edd8d0c into main Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants