Fix incorrect key scrubbing

achamayou · Nov 3, 2023 · f6b07de · f6b07de
1 parent 7aed19e
commit f6b07de
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/js/crypto.cpp b/src/js/crypto.cpp
@@ -607,7 +607,7 @@ namespace ccf::js
         std::vector<uint8_t> wrapped_key =
           crypto::ckm_aes_key_wrap_pad(privateKey, {key, key + key_size});
 
-        OPENSSL_cleanse(&privateKey, sizeof(privateKey));
+        OPENSSL_cleanse(privateKey.data(), privateKey.size());
 
         return JS_NewArrayBufferCopy(
           ctx, wrapped_key.data(), wrapped_key.size());
@@ -738,7 +738,7 @@ namespace ccf::js
         std::vector<uint8_t> unwrapped_key =
           crypto::ckm_aes_key_unwrap_pad(privateKey, {key, key + key_size});
 
-        OPENSSL_cleanse(&privateKey, sizeof(privateKey));
+        OPENSSL_cleanse(privateKey.data(), privateKey.size());
 
         return JS_NewArrayBufferCopy(
           ctx, unwrapped_key.data(), unwrapped_key.size());