Simple bash script #183
Open
Simple bash script #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't exists in the original luci file and actually meaningless
|
hi, could you check the PR? This should simplify installation from Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenWRTInvasion depends on Python which may be a problem for users on Windows.
Also it's many things are happening in the script which are not necessary.
I don't need to get a Telnet/SSH server on the router I just want to flush an OpenWrt on it.
So here is my version of a simple script: it will download OpenWrt images, prepare the payload.tar.gz, then it will ask for an URL of the router admin panel and will just POST the payload.
It's easier to understand and modify for most users. I didn't get how to install the OpenWrt by just reading the README and had to learn and modify it.
The bash and curl can be easier to install on Windows because they are installed with Git. Many users already have it.
Later we can port the script to PowerShell or .bat or bat to simplify life for users.
UPD Just found that someone already tried a Windows only installer:
https://openwrt.org/inbox/toh/xiaomi/xiaomi_mi_router_4a_gigabit_edition#microsoft_windows_installation_instructions_for_r4a_gigabit
I'll check it later but still my script looks valuable.