Warn windows compatibility issues #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A PSA advice to not use windows when using the script
acecilia
reviewed
Sep 4, 2022
| @@ -17,7 +17,6 @@ | |||
| import shutil | |||
| import tarfile | |||
| import requests | |||
| import sys | |||
There was a problem hiding this comment.
Why is sys removed? Edit: I am happy with the changes in the readme. If you revert this change in the script, I am happy to merge this PR :)
|
Thanks for this! Solved in ab14f16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue when using windows when executing the exploit script
The script acts like the execution has finished, however issues like
similar to
#142 , #143 , and #141 Might be related to this as well
The purpose of this PR is to warn users about issues they might encounter and to reduce scratching in their heads why this might not be working just as a small reminder on the README