Read Set-Cookie header options from Session plug's options

[sylph01]

Rationale

This is related to #186 (specifically "Add an interface to Antikythera.Plug.Session.load/2"), but it stems from a different purpose, where we needed to explicitly set the expiration period of the session cookie.
This enables the gear to specify the behavior of the session cookie via the keyword list passed to the plug.

Part that I may need help on

• Type signature of load/2 's opts variable. The keyword list should accept a map (which is passed to make_before_send/3), but this specification might be too broad
  • Note: I have ran mix dialyzer and got no warnings
• Are there any test codes relating to this specific code?
• What to do if store is not a cookie?

[irisTa56]

Are there any test codes relating to this specific code?

I couldn't find such test in this repository...
but I found related tests here in testgear repository.

What to do if store is not a cookie?

I'm not sure because I don't know the detailed requirement, but
can it be solved by adding a new store module which implements Antikythera.Session.Store?

[irisTa56]

LGTM!

[Fumipo-Theta]

LGTM!

[aYukiSekiguchi]

Are there any test codes relating to this specific code?

I couldn't find such test in this repository...
but I found related tests here in testgear repository.

I don't think you need to write test code for testgear, but I want to confirm that you manually tested this.

[aYukiSekiguchi]

What to do if store is not a cookie?

I'm not sure what Uses cookie store by default means. However, it looks like session data is always stored in cookie, and Antikythera.Session.Cookie just encodes/decodes data to/from JSON. Therefore, your set_cookie_opts looks correct approach.

[aYukiSekiguchi]

LGTM if you have tested this PR

[sylph01]

please wait while I prepare some evidence 🙇

[aMasakiTakahashi]

LGTM!

[sylph01]

I got some evidence of how this works.

Prerequisites

• antikythera_dep = {:antikythera, [github: "sylph01/antikythera", ref: "2479a8d8cad17c63d000782b5c0e432ade970aca"]} in antikythera_instance_example 's mix.exs
  • the commit hash points to the HEAD of this branch
• then in local testgear, do following to compile/run with specified version of antikythera (change path to your environment accordingly):

ANTIKYTHERA_INSTANCE_DEP='{:antikythera_instance_example, [git: "/home/sylph01/work/antikythera_instance_example"]}' mix deps.get
ANTIKYTHERA_INSTANCE_DEP='{:antikythera_instance_example, [git: "/home/sylph01/work/antikythera_instance_example"]}' mix compile
ANTIKYTHERA_INSTANCE_DEP='{:antikythera_instance_example, [git: "/home/sylph01/work/antikythera_instance_example"]}' iex -S mix

Actual evidence

In testgear's /web/controller/session.ex, I changed the plug line to add max_age option:

Before

After

Note that the new Set-Cookie header has the Max-Age value.

[aYukiSekiguchi]

Great! Thank you!