more fix

abtink · Sep 11, 2023 · 13a0410 · 13a0410
1 parent 127cdee
commit 13a0410
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/mdns/mdns_mdnssd.cpp b/src/mdns/mdns_mdnssd.cpp
@@ -367,6 +367,13 @@ void PublisherMDnsSd::Process(const MainloopContext &aMainloop)
         if (error == kDNSServiceErr_ServiceNotRunning)
         {
             otbrLogWarning("Need to reconnect to mdnsd");
+
+            if (mHostsRef != nullptr)
+            {
+                DNSServiceRefDeallocate(mHostsRef);
+                mHostsRef = nullptr;
+            }
+
             Stop();
             Start();
             ExitNow();
@@ -400,6 +407,7 @@ PublisherMDnsSd::DnssdHostRegistration::~DnssdHostRegistration(void)
 {
     int dnsError;
 
+    VerifyOrExit(GetPublisher().mHostsRef != nullptr);
     VerifyOrExit(mServiceRef != nullptr);
 
     for (const auto &recordRefAndAddress : GetRecordRefMap())

diff --git a/src/mdns/mdns_mdnssd.hpp b/src/mdns/mdns_mdnssd.hpp
@@ -156,6 +156,8 @@ class PublisherMDnsSd : public MainloopProcessor, public Publisher
         std::map<DNSRecordRef, Ip6Address>       &GetRecordRefMap() { return mRecordRefMap; }
 
     private:
+        PublisherMDnsSd &GetPublisher(void) { return *static_cast<PublisherMDnsSd *>(mPublisher); }
+
         DNSServiceRef mServiceRef;
 
     public: