Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for Gentoo and Solaris #168

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

Add basic support for Gentoo and Solaris #168

wants to merge 2 commits into from

Conversation

sst-yde
Copy link

@sst-yde sst-yde commented Jan 29, 2018

No description provided.

@sst-yde sst-yde force-pushed the gentoo_solaris_support branch from fa7ac38 to 16d791a Compare January 29, 2018 15:20
rendhalver
rendhalver requested changes Jan 29, 2018
View reviewed changes
Copy link
Member

@rendhalver rendhalver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.
I am only testing the code on Ubuntu and CentOS so if you want these tests to run you will need to add them to the "on_supported_os" matrix in each class and defines tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rendhalver rendhalver rendhalver requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sst-yde @rendhalver