Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a reason you can't just do this #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sSolsta
Copy link

@sSolsta sSolsta commented May 10, 2021

is there anything preventing you from just subtracting 300 from the download count and 100 from the like count in the getGJLevels and downloadGJLevel endpoints so that levels visually start at 0 downloads and 0 likes

@tzt345
Copy link

tzt345 commented May 28, 2021

@absoIute Help Plz
Screenshot_2021-05-28-23-52-04-30

@sSolsta
Copy link
Author

sSolsta commented May 28, 2021

@tzt345 not here

@qimiko
Copy link

qimiko commented Jun 9, 2021

there's nothing stopping one from setting the default to 0 here either, but i suppose it's too late to change that 😝

1.9-GDPS/database.sql

Lines 308 to 309 in 4c02f9c

`downloads` int(11) NOT NULL DEFAULT '300',
`likes` int(11) NOT NULL DEFAULT '100',

@notqoid
Copy link

notqoid commented Aug 6, 2021

i know im years late but go to the structures button in levels tab and change the downloads and likes to 0

@sSolsta
Copy link
Author

sSolsta commented Aug 13, 2021

i know im years late but go to the structures button in levels tab and change the downloads and likes to 0

the what in the what

@qimiko
Copy link

qimiko commented Aug 13, 2021

i assume they're a phpmyadmin user or something lol

@notqoid
Copy link

notqoid commented Aug 26, 2021

i assume they're a phpmyadmin user or something lol

I've been in gdps free hosting for 8 months. of course i know how this works

@efwxx
Copy link

efwxx commented Aug 26, 2021

@notqoid
lad they're talking about the code not phpmyadmin, you sure you "know pretty much everything about gdps hosting and stuff"?

Copy link

@efwxx efwxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a pretty solid workaround in my eyes* not gonna lie. 👍

@RealistikDash
Copy link

Literally just change the default value for likes and downloads to 0. No need for a hacky workaround. Can be done in the schema or through Phpmyadmin.

@RealistikDash
Copy link

If you have an existing database affected by this, you can solve it by setting the default values for likes and downloads to 0, and the proceeding to run the following queries:

UPDATE levels SET likes = likes - 100, downloads = downloads - 300

@qimiko
Copy link

qimiko commented Aug 26, 2021

If you have an existing database affected by this, you can solve it by setting the default values for likes and downloads to 0, and the proceeding to run the following queries:

UPDATE levels SET likes = likes - 100, downloads = downloads - 300

this would be the preferred method to this pull request, which only visually changes likes and may introduce issues in areas of the server which interact with the like counts in the db
that is, if we even want to go this route. there is value in making a server look more popular than it actually is, after all. i would go the route of tweaking the download/like ratio to better reflect the current ratio instead of removing this altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants