Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unizen staking contract #243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

minapham17
Copy link

Add Unizen staking contract on Polygon network

@alokt
Copy link
Contributor

alokt commented Jul 2, 2024

@minapham17 can you please resolve conflicts?

@minapham17
Copy link
Author

@alokt conflict resolved. thank you

@alokt
Copy link
Contributor

alokt commented Jul 2, 2024

@minapham17 is it working locally? because test case is failing. can you please check
https://github.com/abridged/collabland-staking-contracts/actions/runs/9755711957/job/26946306312?pr=243

Signed-off-by: minapham17 <[email protected]>
@minapham17
Copy link
Author

@alokt I fixed the issue, and now the test should work. During the testing process, I noticed something important:

For the same static call to our contract, it seems that the RPC is not very stable during the test. This means it can succeed at one moment but fail a few seconds later if I run the test again.

To handle this, I added a try-catch block to prevent failed tests due to the RPC status. Thank you for your review and please let me know if I need to change anything.

@minapham17
Copy link
Author

@alokt just reminder in case you missed my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants