Added the ability to specify a custom file name

[antolopez]

If the temporary URL has the filename parameter, it will be used as the file name when downloaded.

Example:

        Storage::disk('local')->temporaryUrl($path, now()->addMinutes(5),  ['filename' => $filename]);

[abrardev99]

I don't think getting it from the request class is a good idea. Maybe we can add a route parameter here, which will accept the name through the Storage temporaryUrl function.
I will look into this weekend.

[abrardev99]

I looked into the code and I think you can already pass file by without this PR. Example

Storage::disk('local')->temporaryUrl('file.txt', now()->addMinutes(5), ['filename' => 'customname']);

Not just file name, you can pass other options as well (with respect to disk)

[
  'ResponseContentType' => 'application/octet-stream',
  'ResponseContentDisposition' => 'attachment; filename=file2.jpg',
]

[antolopez]

Hi, regarding the fact of using the request to obtain the parameter, there is no problem because the request is signed, including the parameters, so the established parameters cannot be changed after creating the temporary URL on the server.

And as for the last thing you mentioned, the problem is not what can be passed, which, as you said, when creating the link, anything can be passed. The problem is that the package route code ignores any parameters that might have been passed, making it not feasible without overwriting the route.

If the route is not going to be modified, could you at least add a package configuration so that the route file is not included?

Something like this:

` public function configurePackage(Package $package): void
{
$configuredPackage = $package
->name('laravel-local-temporary-url')
->hasConfigFile();

    if (!config('local-temporary-url.ignore_routes'))
        $configuredPackage->hasRoute('routes');
}`

[abrardev99]

The route does not ignore any options you pass using

Storage::disk('local')->temporaryUrl('file.txt', now()->addMinutes(5), ['filename' => 'customname']);

Output:

See route https://github.com/abrardev99/laravel-local-temporary-url/blob/main/src/LocalTemporaryUrlServiceProvider.php#L25, its accepting options. I tried locally and its accept file finames

[antolopez]

Hi, regarding the part you mentioned, there is no problem and nothing needs to be modified. The temporary URL generation is perfect.

The problem lies in the route that listens to those URLs, which does not take the parameters into account when generating the download.

https://github.com/abrardev99/laravel-local-temporary-url/blob/main/routes/routes.php

<?php

use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\Storage;

foreach (config('local-temporary-url.disk') as $disk) {
    Route::get("$disk/temp/{path}", function (string $path) use ($disk) {
        return Storage::disk($disk)->download($path);
    })
        ->where('path', '.*')
        ->middleware(config('local-temporary-url.middleware'))
        ->name("$disk.temp");
}

That’s why I suggested adding the configuration to the package to ignore this route, allowing it to be customized if you don’t want to modify it, to permit custom names and/or other options for the file download.

[abrardev99]

This route is not meant to use "separately" by developers, its being used internally by temporaryUrl method.