Added new fields: action (TM2j) and serial (TM2k). #43
Conversation
|
|
||
| ## enum MessageAction | ||
|
|
||
| Describes the possible actions message can represent (in order from zero). |
There was a problem hiding this comment.
Where did these descriptions come from? It's not very clear to me from looking at these how a user of the library is meant to use these actions or the two new Message fields.
| @@ -636,6 +651,8 @@ Contains an individual message that is sent to, or received from, Ably. | |||
| | id: String ||| TM2a | A Unique ID assigned by Ably to this message. | | |||
| | name: String? ||| TM2g | The event name. | | |||
| | timestamp: Time ||| TM2f | Timestamp of when the message was received by Ably, as milliseconds since the Unix epoch. | | |||
| | action: MessageAction ||| TM2j | The [`MessageAction`]{@link MessageAction} this message represents. | | |||
| | serial: String? ||| TM2k | An opaque string that uniquely identifies the message. | | |||
There was a problem hiding this comment.
It's not optional in the IDL. Also, how is this different to id?
|
This stuff should have had docstrings added here when it was added to the spec. Somebody has added them in JS already, it seems. https://github.com/ably/ably-js/blob/18a255948c38d1e60715c8f5d6173369b57cb8d6/ably.d.ts#L2337-L2429. Could you find out who did this work (because they probably are much better positioned to write meaningful docstrings for these changes, which mean nothing to me) and ask them to add the docstrings to this repo? |
Part of a bigger task (ably/ably-cocoa#2000).