Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont crash threadless if work shutdown errors out #1509

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

abhinavsingh
Copy link
Owner

No description provided.

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.61%. Comparing base (5076c30) to head (71eb1d6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
proxy/core/work/threadless.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1509      +/-   ##
===========================================
- Coverage    84.63%   84.61%   -0.02%     
===========================================
  Files          184      184              
  Lines         8361     8364       +3     
  Branches      1276     1276              
===========================================
+ Hits          7076     7077       +1     
- Misses        1080     1082       +2     
  Partials       205      205              
Flag Coverage Δ
GHA 84.45% <71.42%> (-0.02%) ⬇️
Linux 84.09% <71.42%> (-0.02%) ⬇️
Python 3.10 85.13% <71.42%> (-0.03%) ⬇️
Python 3.11 84.34% <71.42%> (-0.02%) ⬇️
Python 3.12 84.34% <71.42%> (-0.02%) ⬇️
Python 3.6 85.09% <71.42%> (-0.03%) ⬇️
Python 3.7 85.09% <71.42%> (-0.03%) ⬇️
Python 3.8 85.12% <71.42%> (-0.03%) ⬇️
Python 3.9 85.19% <71.42%> (-0.03%) ⬇️
Windows 77.84% <0.00%> (-0.03%) ⬇️
macOS 84.42% <71.42%> (-0.02%) ⬇️
pytest 84.45% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@abhinavsingh abhinavsingh merged commit 71d796b into develop Nov 22, 2024
52 of 53 checks passed
@abhinavsingh abhinavsingh deleted the protect-threadless-from-work-shutdown-errors branch November 22, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant